Vehicle perks and weapons - #295
Merged
Merged
Conversation
Owner
|
Thanks a lot! Looking really good. Will hopefully find some time this evening to test (and then merge) this. |
Joe91
reviewed
Jul 18, 2023
Owner
There was a problem hiding this comment.
I don't think that the parts for the secondary weapon of the first seat are correct.
But I think I will just merge it and have a look at it afterwards. Thanks a lot for this contribution! I have huge respect of you understanding all the stuff happening there and improve on it!!!
| Type = VehicleTypes.Tank, | ||
| Terrain = VehicleTerrains.Land, | ||
| Parts = { 26, -1, -1, -1, -1 }, | ||
| Parts = { {26, 1}, -1, -1, -1, -1 }, |
Owner
There was a problem hiding this comment.
Has to be {{26, 26}, ... for this vehicle. I think for most of the others as well the same movable-parts-id...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.