fix(RavenDB): Node sequence startup race#3352
Merged
jeremydmiller merged 2 commits intoJul 10, 2026
Merged
Conversation
Member
|
@danielwinkler I'd rather just get this in if you're okay with that. |
This was referenced Jul 10, 2026
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During startup, when multiple Wolverine nodes registered concurrently against RavenDB,
PersistAsynccould hand out duplicateAssignedNodeNumbers. Each concurrent call loaded the sameNodeSequencedocument, incrementedCountto the same value, and committed — so two nodes could end up with the same assigned number.Fix
RavenDbMessageStore.PersistAsyncnow retries the load/increment/store cycle inside a bounded loop, relying on RavenDB cluster-wide transaction concurrency (compare-exchange atomic guards onnodes/sequence) to detect the collision:ClusterTransactionConcurrencyException/ConcurrencyExceptionand retries (up to 25 attempts).InvalidOperationException(with the last conflict as inner exception) if the sequence keeps conflicting past the attempt limit.Tests
Added
concurrently_persisting_nodes_assigns_unique_node_numbersto the RavenDB node-persistence compliance suite. It fires 20PersistAsynccalls simultaneously (released via a sharedTaskCompletionSource) and asserts the returned numbers — and the persisted DB state — form exactly1..20with no duplicates.Notes
UseOptimisticConcurrency = false, which is the mechanism the retry leans on.Want me to commit and push this, or adjust the tone/length for the repo's PR conventions?