Add GCP Pub/Sub CI coverage (#3191)#3193
Merged
Merged
Conversation
The GCP Pub/Sub transport had no CI job — no CIPubsub Nuke target and no entry in the consolidated tests workflow — so its compliance suite never ran in CI and regressions shipped undetected (e.g. the reply-subject collision found in #3189). - Add a CIPubsub target (build Wolverine.Pubsub.Tests, start the gcp-pubsub emulator + postgresql, run the suite) and a WaitForPubsubEmulatorToBeReady() TCP readiness poll on 8085. - Add CIPubsub to the matrix in .github/workflows/tests.yml. - Point the test emulator host at localhost:8085 instead of the IPv6 literal [::1]:8085; CI Linux runners publish the container on IPv4 only. Validated locally via ./build.sh CIPubsub: 142/142 Wolverine.Pubsub.Tests green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 23, 2026
Closed
This was referenced Jul 9, 2026
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3191.
GCP Pub/Sub was the one transport with no CI job — no
CIPubsubNuke target and no entry in the consolidatedtests.ymlmatrix — soWolverine.Pubsub.Testsnever ran in CI and regressions shipped undetected. This is exactly why the reply-subject collision uncovered in #3189 wasn't caught automatically for GCP.Changes
build/CITargets.cs— newCIPubsubtarget (buildsWolverine.Pubsub.Tests, starts thegcp-pubsubemulator +postgresqlfor the durable-compliance fixtures, runs the suite) plus aWaitForPubsubEmulatorToBeReady()TCP readiness poll on:8085..github/workflows/tests.yml— addedCIPubsubto the matrix.TestingExtensions.cs— pointPUBSUB_EMULATOR_HOSTatlocalhost:8085instead of the IPv6 literal[::1]:8085; CI Linux runners publish the emulator container on IPv4 only, where[::1]is unreachable.Validation
Ran the exact target locally:
./build.sh CIPubsub --framework net9.0→ 142/142Wolverine.Pubsub.Testsgreen (build + emulator startup + readiness wait + full suite).Note: this branch is off
main, which does not have #3189's "Solo == node 1" change, so GCP gets unique node numbers and the reply tests pass. The GCP reply-collision fix itself rides in #3189.🤖 Generated with Claude Code