Remove duplicate Say To Me ID control - #30
Draft
JLarky wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VoiceNotesBanner.<say-to-me-widget>as the sole owner of ID and Park controls.Dependency
Companion T3 change for Say To Me #619. This PR depends on STM pingdotgg#619 being merged and deployed so the generic widget owns the ID and Park controls. It targets
maindirectly and is not stacked on another feature branch.Validation
VoiceNotesBanner.test.tsx,SayToMeWidgetHost.test.tsx,widget.test.ts).vp run typecheckfromapps/web.vp fmt --checkon both changed files.vp linton both changed files; one existingprefer-add-event-listenerwarning remains inVoiceNotesBanner.tsx:573.node-ptyforlinux-arm64(pty.nodemissing), so no pairing URL was available. The web process itself served HTTP 200 onhttp://localhost:5733/.