Skip to content

feat(SDK-521): tighten TurboModule bridge type safety#883

Open
jferrao-itrbl wants to merge 1 commit into
masterfrom
feature/SDK-521-tighten-turbomodule-bridge-type-safety
Open

feat(SDK-521): tighten TurboModule bridge type safety#883
jferrao-itrbl wants to merge 1 commit into
masterfrom
feature/SDK-521-tighten-turbomodule-bridge-type-safety

Conversation

@jferrao-itrbl

@jferrao-itrbl jferrao-itrbl commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

🔹 JIRA Ticket(s) if any

✏️ Description

  • Replace dictionary types with inline interfaces (CommerceItemSpec, AttributionInfoSpec, InboxImpressionRowSpec) in NativeRNIterableAPI.ts
  • No runtime change; native layers still read by string key
  • Public facade and IterableApi.ts unchanged via structural compatibility (no casts)
  • dataFields uses unknown (Codegen-equivalent to Object) to preserve assignability from IterableCommerceItem

…structs

- Replace dictionary types with inline interfaces (CommerceItemSpec,
  AttributionInfoSpec, InboxImpressionRowSpec) in NativeRNIterableAPI.ts
- No runtime change; native layers still read by string key
- Public facade and IterableApi.ts unchanged via structural compatibility (no casts)
- dataFields uses `unknown` (Codegen-equivalent to `Object`) to preserve
  assignability from IterableCommerceItem
@jferrao-itrbl jferrao-itrbl requested a review from a team July 7, 2026 15:55
@qltysh

qltysh Bot commented Jul 7, 2026

Copy link
Copy Markdown

Qlty


⚠️ Comments skipped @jferrao-itrbl doesn't have a Qlty seat in Iterable.

Qlty doesn't post analysis or coverage comments for contributors without a seat. An authorized user can grant @jferrao-itrbl a seat from this pull request's page in Qlty.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Lines Statements Branches Functions
Coverage: 71%
71.07% (538/757) 60.55% (218/360) 66.66% (170/255)

@joaodordio joaodordio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants