fix(test-utils): validate fixture paths against repo root#7
Open
piyushbag wants to merge 1 commit into
Open
Conversation
Reject parent-dir segments and paths outside the repository when loading program bytecode or lookup-table JSON in the LiteSVM test framework. Fixes Instadapp#5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Aikido flagged path traversal in the LiteSVM test framework where program bytecode and lookup-table JSON paths were read without validating they stay inside the repository.
Approach
validate_readable_pathhelper that rejects..segments and canonicalizes paths against the repo root.Vm::add_program_from_fileandLookupTableHelper::load_lookup_table_from_file.Test plan
cargo test helpers::pathintest-utils/rustFixes #5