Repository navigation
Fixing external tools with guestbook responses - #12801
Open
stevenwinship wants to merge 2 commits into
Open
stevenwinship wants to merge 2 commits into
stevenwinship wants to merge 2 commits into
Conversation
stevenwinship
added
Size: 30
|
Coverage is 25.553% — 12760-previewers-not-working-with-guestbook-responses into develop. No base build found for |
This comment has been minimized.
This comment has been minimized.
Test Results407 tests 392 ✅ 32m 23s ⏱️ Results for commit 86741c7. ♻️ This comment has been updated with latest results. |
|
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: External tools can't download files that require/have a guestbook response
Which issue(s) this PR closes:#12760
Special notes for your reviewer:
Suggestions on how to test this: Create a dataset with multiple files to preview. Add a guestbook to the dataset and publish. Test previewing the files and download from the external tool. Test files with restricted access.
Download timeout was increased from 1 minute to 5 minutes. Verify the user has more time to download.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: