fix: validate deep binary expressions iteratively#6805
Open
martinfrancois wants to merge 1 commit into
Open
Conversation
martinfrancois
force-pushed
the
agent/issue-6804-deep-binary-validation
branch
2 times, most recently
from
July 17, 2026 19:01
5940010 to
012fcef
Compare
martinfrancois
marked this pull request as ready for review
July 17, 2026 19:12
martinfrancois
force-pushed
the
agent/issue-6804-deep-binary-validation
branch
from
July 17, 2026 20:12
012fcef to
d37d694
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Process very deep binary-expression trees without overflowing the JVM stack.
Fixes #6804.
Problem
OpenJDK's valid
DeepStringConcat.javacontains about 32,000 binary operators in one expression. Spoon recursively visited one operator per JVM frame. It first overflowed while checking parent links and then overflowed while running processors.Change
acceptcall.Validation
mvn -q -Dtest=spoon.reflect.visitor.AstParentConsistencyCheckerTest,spoon.support.visitor.ProcessingVisitorTest,spoon.FluentLauncherTest testpasses all 12 tests.mvn -q -Dtest=spoon.test.architecture.SpoonArchitectureEnforcerTest testpasses all 9 tests. The two focused commands therefore run 21 tests in total.DeepStringConcat.java: exit 0, AST 1/1, and no reported errors.