Skip to content

Improve cert generate.sh script - #138

Closed
lundibundi wants to merge 2 commits into
HowProgrammingWorks:masterfrom
lundibundi:improve-cert-gen
Closed

Improve cert generate.sh script#138
lundibundi wants to merge 2 commits into
HowProgrammingWorks:masterfrom
lundibundi:improve-cert-gen

Conversation

@lundibundi

@lundibundi lundibundi commented May 21, 2020

Copy link
Copy Markdown
Member

Use ECDSA curve ed25519 key instead of RSA.

Minor improvements:

  • Add shebang
  • Fail script if any of the commands fails
  • Make sure to not override existing key without explicit approval
  • Add explanation messages for each step

/cc @tshemsedinov

Use ECDSA curve ed25519 key instead of RSA if possible.

Minor improvements:
* Add shebang
* Make sure to not override existing key without explicit approval
* Add explanation messages for each step
@tshemsedinov tshemsedinov added this to the v2 milestone Jun 9, 2020

@tshemsedinov tshemsedinov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tshemsedinov tshemsedinov self-assigned this Jul 21, 2020
@tshemsedinov tshemsedinov added the enhancement New feature or request label Jul 21, 2020
tshemsedinov pushed a commit that referenced this pull request Jul 21, 2020
Use ECDSA curve ed25519 key instead of RSA if possible.

Minor improvements:
* Add shebang
* Make sure to not override existing key without explicit approval
* Add explanation messages for each step

PR-URL: #138
@tshemsedinov

Copy link
Copy Markdown
Member

Landed in 0328055

RobinzCalvin pushed a commit to RobinzCalvin/NodejsStarter that referenced this pull request Dec 6, 2022
Use ECDSA curve ed25519 key instead of RSA if possible.

Minor improvements:
* Add shebang
* Make sure to not override existing key without explicit approval
* Add explanation messages for each step

PR-URL: HowProgrammingWorks/NodejsStarterKit#138
0xmautone added a commit to 0xmautone/node-web3-boilerplate that referenced this pull request Oct 28, 2024
Use ECDSA curve ed25519 key instead of RSA if possible.

Minor improvements:
* Add shebang
* Make sure to not override existing key without explicit approval
* Add explanation messages for each step

PR-URL: HowProgrammingWorks/NodejsStarterKit#138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants