Return index_url from /installedApps for dashboard app titles - #3352
Merged
Conversation
The dashboard derives a hostname title for anonymous (app-…) apps whose uuid/name/title are all identical, falling back to the host of index_url. That worked for launch/recent apps but not for apps that come only from /installedApps, because the endpoint didn't return index_url. Add apps.index_url to the SELECT (alongside apps.icon, relying on the functional dependency on the apps.id primary key) and assert it in the extension test.
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
velzie
pushed a commit
to velzie/puter
that referenced
this pull request
Jul 12, 2026
…er#3352) The dashboard derives a hostname title for anonymous (app-…) apps whose uuid/name/title are all identical, falling back to the host of index_url. That worked for launch/recent apps but not for apps that come only from /installedApps, because the endpoint didn't return index_url. Add apps.index_url to the SELECT (alongside apps.icon, relying on the functional dependency on the apps.id primary key) and assert it in the extension test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
index_urlto the/installedAppsresponse.Why
The dashboard shows a friendlier title for anonymous apps — those whose
uuid,name, andtitleare all identical and start withapp-. Instead ofthe opaque
app-…id, it displays the hostname of the app'sindex_url.This already worked for apps sourced from the launch-apps list (recent /
recommended), which carry
index_url. But it did not work for apps that comeonly from
/installedApps, because that endpoint'sSELECTdidn't returnindex_url, so the client's fallback could never fire.Change
extensions/installedApps.ts— addapps.index_urlto the query. It sitsalongside
apps.icon(also not in theGROUP BY), relying on the functionaldependency on the
apps.idprimary key, so it's consistent with the existingquery and safe across SQLite/Postgres/MySQL.
extensions/installedApps.test.ts— assertindex_urlis present in theresponse so it can't be silently dropped again.
Testing
vitest runon the extension suite — 5/5 passing, including the new assertion.