chore: remove dead unused design-system folder - #30
Conversation
Confirmed zero consumers via grep for both relative and non-relative imports, plus no barrel re-exports, config, storybook, or test refs.
✅ Deploy Preview for hex-diva ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (2)
⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoRemove unused legacy design-system components
AI Description
Diagram
High-Level Assessment
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
12 rules 1. Stale design-system docs
|
| export const Button = React.forwardRef<HTMLButtonElement, ButtonProps>( | ||
| ( | ||
| { | ||
| variant = 'primary', | ||
| size = 'medium', | ||
| children, | ||
| icon, | ||
| loading = false, | ||
| fullWidth = false, | ||
| disabled, | ||
| className = '', | ||
| ...props | ||
| }, | ||
| ref | ||
| ) => { | ||
| const baseClasses = 'button'; | ||
| const variantClasses = `btn-${variant}`; | ||
| const sizeClasses = size !== 'medium' ? `btn-${size}` : ''; | ||
| const widthClasses = fullWidth ? 'w-full' : ''; | ||
| const disabledClasses = disabled ? 'opacity-50 cursor-not-allowed' : ''; | ||
|
|
||
| const allClasses = [ | ||
| baseClasses, | ||
| variantClasses, | ||
| sizeClasses, | ||
| widthClasses, | ||
| disabledClasses, | ||
| className, | ||
| ] | ||
| .filter(Boolean) | ||
| .join(' '); | ||
|
|
||
| return ( | ||
| <button | ||
| ref={ref} | ||
| className={allClasses} | ||
| disabled={disabled || loading} | ||
| {...props} | ||
| > | ||
| {icon && <span className="button-icon">{icon}</span>} | ||
| {children} | ||
| {loading && <span className="button-loader">…</span>} | ||
| </button> | ||
| ); | ||
| } | ||
| ); |
There was a problem hiding this comment.
1. Stale design-system docs 🐞 Bug ⚙ Maintainability
The PR removes the legacy src/components/design-system components, but docs still instruct importing from @/components/design-system and a legacy CSS entrypoint, so the integration guide/setup docs will now lead developers to module-not-found errors and incorrect setup steps.
Agent Prompt
### Issue description
The legacy design-system components were deleted, but repository documentation still references them (and their CSS import path). Update/remove these references so contributors are not directed to import a non-existent module.
### Issue Context
The app has already moved to `@astryxdesign/*` CSS imports in the Next.js root layout, but docs still present the old design-system integration instructions.
### Fix Focus Areas
- docs/COMPONENT_INTEGRATION_GUIDE.md[24-50]
- docs/COMPONENT_INTEGRATION_GUIDE.md[182-240]
- docs/COMPONENT_INTEGRATION_GUIDE.md[670-818]
- docs/COMPONENT_INTEGRATION_GUIDE.md[924-928]
- TRACKS_SETUP.md[58-60]
- src/app/layout.tsx[4-9]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
COMPONENT_INTEGRATION_GUIDE.md documented the now-deleted homegrown design-system folder; replaced with a pointer to the real, in-use Astryx pattern and live example files. TRACKS_SETUP.md is a historical planning doc, annotated rather than rewritten. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Summary
src/components/design-system/(Button.tsx, Card.tsx) — a homegrown, pre-Astryx design system with zero consumers anywhere in the codebase.@astryxdesign/core.Verification
grep -rl "from '@/components/design-system" src --include="*.tsx"-> emptygrep -rl "design-system" src-> emptypnpm exec tsc --noEmit-> cleanpnpm lint-> 0 errors (4 pre-existing unrelated warnings)Test plan
Summary by Sourcery
Enhancements:
Summary by cubic
Removed the unused design system at
src/components/design-system/(Button.tsx, Card.tsx). It's replaced by@astryxdesign/core; no references remain, and typecheck/lint pass.Written for commit 5bb7be4. Summary will update on new commits.