Skip to content

chore: remove dead unused design-system folder - #30

Open
TechHypeXP wants to merge 1 commit into
mainfrom
chore/remove-dead-design-system
Open

chore: remove dead unused design-system folder#30
TechHypeXP wants to merge 1 commit into
mainfrom
chore/remove-dead-design-system

Conversation

@TechHypeXP

@TechHypeXP TechHypeXP commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Deletes src/components/design-system/ (Button.tsx, Card.tsx) — a homegrown, pre-Astryx design system with zero consumers anywhere in the codebase.
  • Superseded by @astryxdesign/core.

Verification

  • grep -rl "from '@/components/design-system" src --include="*.tsx" -> empty
  • grep -rl "design-system" src -> empty
  • No barrel/index re-exports, config, storybook, or test references found
  • pnpm exec tsc --noEmit -> clean
  • pnpm lint -> 0 errors (4 pre-existing unrelated warnings)

Test plan

  • Confirmed no references before deletion
  • Typecheck passes
  • Lint passes

Summary by Sourcery

Enhancements:

  • Delete the obsolete Button and Card components under src/components/design-system that are no longer referenced anywhere.

Summary by cubic

Removed the unused design system at src/components/design-system/ (Button.tsx, Card.tsx). It's replaced by @astryxdesign/core; no references remain, and typecheck/lint pass.

Written for commit 5bb7be4. Summary will update on new commits.

Review in cubic

Confirmed zero consumers via grep for both relative and non-relative
imports, plus no barrel re-exports, config, storybook, or test refs.
@netlify

netlify Bot commented Jul 25, 2026

Copy link
Copy Markdown

Deploy Preview for hex-diva ready!

Name Link
🔨 Latest commit 5bb7be4
🔍 Latest deploy log https://app.netlify.com/projects/hex-diva/deploys/6a652865a799d900089c5678
😎 Deploy Preview https://deploy-preview-30--hex-diva.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hex-diva Ready Ready Preview, Comment Jul 25, 2026 9:20pm

@sourcery-ai

sourcery-ai Bot commented Jul 25, 2026

Copy link
Copy Markdown

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (2)
  • src/components/design-system/Button.tsx
  • src/components/design-system/Card.tsx
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7cb4740a-9d68-4d28-8603-c7ee43d49566

📥 Commits

Reviewing files that changed from the base of the PR and between ef61d22 and 5bb7be4.

📒 Files selected for processing (2)
  • src/components/design-system/Button.tsx
  • src/components/design-system/Card.tsx

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-dead-design-system
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch chore/remove-dead-design-system

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Remove unused legacy design-system components

✨ Enhancement 🕐 Less than 10 minutes

Grey Divider

AI Description

• Delete the unused legacy src/components/design-system Button/Card components.
• Reduce maintenance surface area now that UI is provided by @astryxdesign/core.
• Keep build/lint green by removing only code with zero in-repo consumers.
Diagram

graph TD
  A["App UI"] --> B["Component layer"] --> C{{"@astryxdesign/core"}}
  B -. "removed" .-> D["legacy design-system"]
Loading
High-Level Assessment

Deleting the unused folder is the right approach since there are no in-repo consumers and the functionality is superseded by @astryxdesign/core. The only meaningful alternative (keeping the code as a fallback) adds maintenance burden without providing value.

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

Context used
✅ Compliance rules (platform): 12 rules

Grey Divider


Remediation recommended

1. Stale design-system docs 🐞 Bug ⚙ Maintainability
Description
The PR removes the legacy src/components/design-system components, but docs still instruct
importing from @/components/design-system and a legacy CSS entrypoint, so the integration
guide/setup docs will now lead developers to module-not-found errors and incorrect setup steps.
Code

src/components/design-system/Button.tsx[L22-67]

-export const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
-  (
-    {
-      variant = 'primary',
-      size = 'medium',
-      children,
-      icon,
-      loading = false,
-      fullWidth = false,
-      disabled,
-      className = '',
-      ...props
-    },
-    ref
-  ) => {
-    const baseClasses = 'button';
-    const variantClasses = `btn-${variant}`;
-    const sizeClasses = size !== 'medium' ? `btn-${size}` : '';
-    const widthClasses = fullWidth ? 'w-full' : '';
-    const disabledClasses = disabled ? 'opacity-50 cursor-not-allowed' : '';
-
-    const allClasses = [
-      baseClasses,
-      variantClasses,
-      sizeClasses,
-      widthClasses,
-      disabledClasses,
-      className,
-    ]
-      .filter(Boolean)
-      .join(' ');
-
-    return (
-      <button
-        ref={ref}
-        className={allClasses}
-        disabled={disabled || loading}
-        {...props}
-      >
-        {icon && <span className="button-icon">{icon}</span>}
-        {children}
-        {loading && <span className="button-loader">…</span>}
-      </button>
-    );
-  }
-);
Relevance

⭐⭐⭐ High

Docs pointing to deleted imports will cause module-not-found; teams typically accept keeping
integration guides accurate.

PR-#23

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The integration guide repeatedly instructs importing components from @/components/design-system,
and TRACKS_SETUP still lists that deleted directory as an output; meanwhile the actual app layout
imports Astryx design-system CSS packages, confirming the legacy guidance is out of date after this
deletion.

docs/COMPONENT_INTEGRATION_GUIDE.md[24-50]
docs/COMPONENT_INTEGRATION_GUIDE.md[182-240]
docs/COMPONENT_INTEGRATION_GUIDE.md[670-818]
docs/COMPONENT_INTEGRATION_GUIDE.md[924-928]
TRACKS_SETUP.md[58-60]
src/app/layout.tsx[4-9]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The legacy design-system components were deleted, but repository documentation still references them (and their CSS import path). Update/remove these references so contributors are not directed to import a non-existent module.

### Issue Context
The app has already moved to `@astryxdesign/*` CSS imports in the Next.js root layout, but docs still present the old design-system integration instructions.

### Fix Focus Areas
- docs/COMPONENT_INTEGRATION_GUIDE.md[24-50]
- docs/COMPONENT_INTEGRATION_GUIDE.md[182-240]
- docs/COMPONENT_INTEGRATION_GUIDE.md[670-818]
- docs/COMPONENT_INTEGRATION_GUIDE.md[924-928]
- TRACKS_SETUP.md[58-60]
- src/app/layout.tsx[4-9]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

Comment on lines -22 to -67
export const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
(
{
variant = 'primary',
size = 'medium',
children,
icon,
loading = false,
fullWidth = false,
disabled,
className = '',
...props
},
ref
) => {
const baseClasses = 'button';
const variantClasses = `btn-${variant}`;
const sizeClasses = size !== 'medium' ? `btn-${size}` : '';
const widthClasses = fullWidth ? 'w-full' : '';
const disabledClasses = disabled ? 'opacity-50 cursor-not-allowed' : '';

const allClasses = [
baseClasses,
variantClasses,
sizeClasses,
widthClasses,
disabledClasses,
className,
]
.filter(Boolean)
.join(' ');

return (
<button
ref={ref}
className={allClasses}
disabled={disabled || loading}
{...props}
>
{icon && <span className="button-icon">{icon}</span>}
{children}
{loading && <span className="button-loader">…</span>}
</button>
);
}
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. Stale design-system docs 🐞 Bug ⚙ Maintainability

The PR removes the legacy src/components/design-system components, but docs still instruct
importing from @/components/design-system and a legacy CSS entrypoint, so the integration
guide/setup docs will now lead developers to module-not-found errors and incorrect setup steps.
Agent Prompt
### Issue description
The legacy design-system components were deleted, but repository documentation still references them (and their CSS import path). Update/remove these references so contributors are not directed to import a non-existent module.

### Issue Context
The app has already moved to `@astryxdesign/*` CSS imports in the Next.js root layout, but docs still present the old design-system integration instructions.

### Fix Focus Areas
- docs/COMPONENT_INTEGRATION_GUIDE.md[24-50]
- docs/COMPONENT_INTEGRATION_GUIDE.md[182-240]
- docs/COMPONENT_INTEGRATION_GUIDE.md[670-818]
- docs/COMPONENT_INTEGRATION_GUIDE.md[924-928]
- TRACKS_SETUP.md[58-60]
- src/app/layout.tsx[4-9]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

TechHypeXP pushed a commit that referenced this pull request Jul 26, 2026
COMPONENT_INTEGRATION_GUIDE.md documented the now-deleted homegrown
design-system folder; replaced with a pointer to the real, in-use
Astryx pattern and live example files. TRACKS_SETUP.md is a historical
planning doc, annotated rather than rewritten.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants