chore(deps): update pin digests (major) - #620
Conversation
57b6015 to
2d8d050
Compare
dawsontoth
left a comment
There was a problem hiding this comment.
Approving — all 22 checks green (5 skipped). Two genuine majors in here, both verified.
Digests both match their real upstream tags:
actions/setup-node@820762786026740c76f36085b0efc47a31fe5020= v7.0.0 ✅slackapi/slack-github-action@dcb1066f776dd043e64d0e8ba94ca15cc7e1875d= v4.0.0 ✅
slack-github-action v3.0.5 → v4.0.0 — the sole major change is stricter YAML parsing via js-yaml@v5:
Indentation is now required for values that span multiple lines against the base value.
This only bites plain multiline scalars. I checked all 11 call sites across publish-docker.yaml, create-release.yaml, publish-npm.yaml, and notify-release-published.yaml — every one passes its payload as a payload: | literal block containing indented JSON, e.g.:
payload: |
{
"channel": "#development-ci",
"text": "Harper Pro ${{ github.event.release.tag_name }} GitHub release published",Literal block scalars take their content verbatim, so the new indentation rule doesn't apply. No payload uses a plain multiline value. ✅
actions/setup-node v7 — the notable change is removing the dummy NODE_AUTH_TOKEN export, which is a fix for OIDC publishing rather than a risk.
Flagging that this touches 13 workflows including publish-npm.yaml, publish-docker.yaml, and create-release.yaml — none of which PR CI exercises. The Slack notifications and publish steps get their first real run at the next release.
|
Heads up: this has gone to a conflicted merge state, and #619 is the reason — the two PRs overlap on all 11 workflow files and rewrite the same My approval above stands on the content. Since v7.0.0 supersedes v6.5.0, simplest path is to merge this one and let Renovate retire #619 — otherwise merge #619 first and this needs a rebase to reapply cleanly. |
2d8d050 to
89d19d9
Compare
This PR contains the following updates:
v6.5.0→v7.0.0v3.0.5→v4.0.0Release Notes
actions/setup-node (actions/setup-node)
v7.0.0Compare Source
What's Changed
Enhancements:
Bug fixes:
mirrorTokeningetManifestif it's provided by @deiga in #1548Documentation updates:
Dependency update:
New Contributors
Full Changelog: actions/setup-node@v6...v7.0.0
v7Compare Source
slackapi/slack-github-action (slackapi/slack-github-action)
v4.0.0: Slack GitHub Action v4.0.0Compare Source
Major Changes
b1974f0: build: parse yaml with more strict multiline indentation rulesInternal dependencies of
js-yaml@v5make YAML parsing more strict and compliant with the YAML specification. Indentation is now required for values that span multiple lines against the base value.See the YAML line prefixes spec for the expected indentation rule:
Patch Changes
654bb72: chore: provide global fetch proxied configurations with updates to web api and webhook packagesv4.0Compare Source
v4Compare Source
Configuration
📅 Schedule: (in timezone America/New_York)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.