Skip to content

添加应用重新加载功能 - #4513

Closed
rootwhois wants to merge 7 commits into
HMCL-dev:mainfrom
rootwhois:dev-add-reload
Closed

添加应用重新加载功能#4513
rootwhois wants to merge 7 commits into
HMCL-dev:mainfrom
rootwhois:dev-add-reload

Conversation

@rootwhois

Copy link
Copy Markdown
Contributor

No description provided.

@Glavo

Glavo commented Sep 19, 2025

Copy link
Copy Markdown
Member

看起来好像和 #4468 部分重复

@rootwhois

Copy link
Copy Markdown
Contributor Author

#4468

本pr的重载功能逻辑:当需要重启生效的配置被修改(目前看到的有关闭动画、抗锯齿、语言切换选项)的时候,在标题栏右侧出现重载按钮,点击进行重载。后续有类似的功能需要实现,添加Property对应的Listener即可。

                config().localizationProperty().addListener(restartButtonListener);
                

@3gf8jv4dv 3gf8jv4dv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我测试了一下。

  • 语言重载目前没看到问题。
  • 抗锯齿重载我目前无法给出结论。
  • 关闭动画重载没有效果。

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/Launcher.java Outdated

@Glavo Glavo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我很怀疑这个“重新加载”功能是否有意义。

需要重新启动才能生效的选项大部分是因为必须在 JavaFX 初始化之前才能应用设置,运行时重新加载不会有任何效果。

private Controllers() {
}

private static void setupFontAntialiasing() {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

重载该选项没有意义,该选项只有在 JavaFX 界面显示前生效。

@burningtnt

Copy link
Copy Markdown
Member

怀疑此功能的意义。

@Glavo

Glavo commented Jan 3, 2026

Copy link
Copy Markdown
Member

考虑到本 PR 很多时候看起来是无效的,我先关了本 PR。

@Glavo Glavo closed this Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants