Feat: Automatically create "mods" folders after installing - #3593
Closed
zkitefly wants to merge 5 commits into
Closed
Feat: Automatically create "mods" folders after installing#3593zkitefly wants to merge 5 commits into
zkitefly wants to merge 5 commits into
Conversation
3gf8jv4dv
suggested changes
Feb 7, 2025
3gf8jv4dv
left a comment
3gf8jv4dv
left a comment
Contributor
There was a problem hiding this comment.
Oh god, you forgot NeoForge.
Member
|
你需要的东西叫做 |
…ge.java Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
3gf8jv4dv
suggested changes
Feb 7, 2025
…ge.java Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Member
Author
|
@Glavo cc？ |
Glavo
changed the title
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/download/InstallersPage.java
burningtnt
reviewed
Sep 29, 2025
| } | ||
|
|
||
| private void createRequiredFolders(String versionName) { | ||
| for (InstallerItem library : group.getLibraries()) { |
Member
There was a problem hiding this comment.
请使用 LibraryAnalyzer 直接分析该版本从而决定该版本是否可以安装模组
Glavo
reviewed
Oct 22, 2025
|
|
||
| LibraryAnalyzer.LibraryType libraryType = LibraryAnalyzer.LibraryType.fromPatchId(libraryId); | ||
| if (libraryType != null) { | ||
| java.io.File versionRoot = repository.getVersionRoot(versionName); |
Member
There was a problem hiding this comment.
mod 文件和 version root 没有强关联，实际不应该在这创建这个文件夹。
Member
|
问题：安装的时候版本隔离设置可能和安装后不同，此时原先创建的 mods 文件夹会失效。本 PR 依然没有解决玩家找不到 mods 文件夹的问题 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.