[AUTOMATED] Update to 150.0.7871.46.0#1170
Closed
vanadium-staging wants to merge 12 commits into
Closed
Conversation
vanadium-staging
force-pushed
the
150.0.7871.46.0
branch
from
June 24, 2026 05:33
7d1d0fd to
c9342a9
Compare
inthewaves
suggested changes
Jun 24, 2026
Comment on lines
+61
to
+67
| + public static void setCommaDelimitedSwitchValue(String name, List<String> value) { | ||
| + if (value.isEmpty()) { | ||
| + CommandLine.getInstance().appendSwitch(name); | ||
| + } else { | ||
| + CommandLine.getInstance().appendSwitchWithValue(name, TextUtils.join(",", value)); | ||
| + } | ||
| + } |
Member
There was a problem hiding this comment.
I think it should remove the switch if the value is empty, e.g. see previous patch:
| '--output', | ||
| 'src/vanadium/android_config/filter_lists/filter_lists_easylist_bulgaria.txt', | ||
| '--urls', | ||
| 'http://stanev.org/abp/adblock_bg.txt'] |
Member
There was a problem hiding this comment.
This is not an https url and will be skipped
Comment on lines
+18
to
+19
| if not url.startswith("https://"): | ||
| continue |
Member
There was a problem hiding this comment.
This will skip non https urls, and thus skip Bulgaria
Comment on lines
+18
to
+31
| if not url.startswith("https://"): | ||
| continue | ||
| context = ssl.create_default_context(ssl.Purpose.SERVER_AUTH) | ||
| context.minimum_version = ssl.TLSVersion.TLSv1_3 | ||
| req = urllib.request.Request(url, headers={'User-Agent': 'Mozilla/5.0'}) | ||
| with urllib.request.urlopen(url=req, context=context, timeout=30) as res: | ||
| while True: | ||
| buf = res.read(4096) | ||
| if not buf: | ||
| break | ||
| args.output.write(buf) | ||
| hasher.update(buf) | ||
| with open('.'.join([args.output.name, 'sha256']), 'w') as f: | ||
| f.write(hasher.hexdigest()) |
Member
There was a problem hiding this comment.
This script doesn't check for network failures, and anything that gets skipped is factored into the hash. It's also not clear what these .txt.sha256 are for, since they're added to .gitignore in src/vanadium/android_config/filter_lists
If the host returned empty body, etc., then it will also write empty file
| + if (vanadiumConfigVersion >= 1) { | ||
| + int order = p.getOrder(); | ||
| + p = new LongClickCopySummaryPreference(requireContext(), null); | ||
| + p = new Preference(requireContext()); |
Member
There was a problem hiding this comment.
Is there a reason for this change away from LongClickCopySummaryPreference to Preference? The config version can no longer be long clicked to copy
Comment on lines
+10
to
+29
| diff --git a/chrome/browser/magic_stack/android/java/src/org/chromium/chrome/browser/magic_stack/HomeModulesConfigManager.java b/chrome/browser/magic_stack/android/java/src/org/chromium/chrome/browser/magic_stack/HomeModulesConfigManager.java | ||
| index 0d80babfbdfb8..887d4fd43352e 100644 | ||
| --- a/chrome/browser/magic_stack/android/java/src/org/chromium/chrome/browser/magic_stack/HomeModulesConfigManager.java | ||
| +++ b/chrome/browser/magic_stack/android/java/src/org/chromium/chrome/browser/magic_stack/HomeModulesConfigManager.java | ||
| @@ -86,7 +86,7 @@ public class HomeModulesConfigManager { | ||
| * @param moduleType {@link ModuleType} needed to be notified to the listeners. | ||
| */ | ||
| public boolean getPrefModuleTypeEnabled(@ModuleType int moduleType) { | ||
| - return mSharedPreferencesManager.readBoolean(getSettingsPreferenceKey(moduleType), true); | ||
| + return mSharedPreferencesManager.readBoolean(getSettingsPreferenceKey(moduleType), false); | ||
| } | ||
|
|
||
| /** | ||
| @@ -103,7 +103,7 @@ public class HomeModulesConfigManager { | ||
| /** Returns the user preference for whether all cards in the magic stack are enabled. */ | ||
| public boolean getPrefAllCardsEnabled() { | ||
| return mSharedPreferencesManager.readBoolean( | ||
| - ChromePreferenceKeys.HOME_MODULE_CARDS_ENABLED, true); | ||
| + ChromePreferenceKeys.HOME_MODULE_CARDS_ENABLED, false); | ||
| } |
Member
There was a problem hiding this comment.
Note that this patch only modifies the getters for these preferences and no longer stubs out the setters. See previous:
vanadium-staging
force-pushed
the
150.0.7871.46.0
branch
8 times, most recently
from
June 24, 2026 20:32
0012c10 to
a35a81d
Compare
inthewaves
approved these changes
Jun 25, 2026
inthewaves
left a comment
inthewaves
left a comment
Member
There was a problem hiding this comment.
Existing WebView compat tests (atest GosCompatWebViewTests) pass
Should be merged with GrapheneOS/grapheneos.org#1553
This will be needed in the next commits
vanadium-staging
force-pushed
the
150.0.7871.46.0
branch
from
June 26, 2026 06:56
a35a81d to
81ca0a2
Compare
inthewaves
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.