Update AppEngine CloudSQL second generation sample#94
Conversation
beccasaurus
commented
Oct 24, 2016
beccasaurus
commented
- Update doc region tags for coming doc updates
- Refactor query onto its own line with comment for clarity in code sample snippet
- Add spec that can be run locally to verify working sample
Update the region so it includes both the mysql2 and sequel gems
- add descriptive comments - move logic onto their own lines to help clarity - Hashing visitor's IP - Fetching recent visits from the database
- Cloud SQL end-to-end test is skipped unless E2E is set to true to disable this test unless explicitly run - Cloud SQL sample spec can be run locally - Sample spec is run on Travis (still not currently running end-to-end)
…ples into cloud-sql-flex-updates
|
|
||
| Capybara.current_driver = :poltergeist | ||
|
|
||
| RSpec.describe "Cloud SQL on Google App Engine", type: :feature do |
There was a problem hiding this comment.
Do we need to set RSpec. here? Looking for consistency.
There was a problem hiding this comment.
Yes, RSpec.describe is used everywhere.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah, looks like some use the global, monkey-patched method. Kk, updated all to prefer describe
|
Additional review of README: |
|
Done ~ ready for review @frankyn |
2 participants
