This repository was archived by the owner on May 16, 2025. It is now read-only.
Using the FQDN of a GCE instance instead of the IP address. - #815
Merged
ivannaranjo merged 5 commits intoOct 3, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #815 +/- ##
==========================================
+ Coverage 11.84% 11.97% +0.13%
==========================================
Files 504 504
Lines 12326 12331 +5
==========================================
+ Hits 1460 1477 +17
+ Misses 10866 10854 -12
Continue to review full report at Codecov.
|
ivannaranjo
changed the title
ILMTitan
suggested changes
Oct 2, 2017
| } | ||
|
|
||
| var reverseIp = string.Join(".", ipAddress.Split('.').Reverse()); | ||
| return $"{reverseIp}.bc.googleusercontent.com"; |
There was a problem hiding this comment.
Create unit tests for this function? You should really only need three cases (null instance, null ipAddress, proper ipAddress).
Contributor
Author
There was a problem hiding this comment.
Ok, will see what I can do.
Contributor
Author
|
Didn't add a case for the PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way we refer to the machine when opening a terminal server session, by using the FQDN of the GCE instance instead of the bare IP address.
Fixes #790