You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expose the part of offset_of! that computes a raw pointer to a field as a separate macro. @Diggseyexpressed that this would be interesting for their crate.
If rust-field-offset could depend on memoffset to use this macro, that would mean there is just one place we have to change once &raw (or an equivalent mechanism) becomes stable, so that everyone uses the blessed way to do this.
@Diggsey does this macro fit the needs of your crate? @Gilnaa are you okay with adding this to the API surface of memoffset?
If there was a crate which implemented this macro: raw_address_of!((*ptr_to_undef).bar) and which guaranteed in the future to compile down to the MIR operator your RFC introduced, whilst for the moment making a "best effort" attempt, then I would be happy to use that to implement (2) in this crate.
@Amanieu this macro has nothing to do with container_of!. It just exposes something that we already did as part of offset_of! before, so there is no change to what happens to provenance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the part of
offset_of!that computes a raw pointer to a field as a separate macro.@Diggsey expressed that this would be interesting for their crate.
If rust-field-offset could depend on memoffset to use this macro, that would mean there is just one place we have to change once
&raw(or an equivalent mechanism) becomes stable, so that everyone uses the blessed way to do this.@Diggsey does this macro fit the needs of your crate?
@Gilnaa are you okay with adding this to the API surface of
memoffset?