[Fix]MicrophoneChecker occasional crash - #813
Merged
Merged
Conversation
Public Interface🚀 No changes affecting the public interface. |
1 similar comment
Public Interface🚀 No changes affecting the public interface. |
Collaborator
SDK Size
|
martinmitrevski
left a comment
martinmitrevski
left a comment
Contributor
There was a problem hiding this comment.
looks good, but there's a test failing
ipavlidakis
force-pushed
the
fix/microphone-crash
branch
from
May 20, 2025 09:33
935b17f to
033a77a
Compare
Public Interface🚀 No changes affecting the public interface. |
Public Interface🚀 No changes affecting the public interface. |
Public Interface🚀 No changes affecting the public interface. |
|
martinmitrevski
approved these changes
May 22, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://linear.app/stream/issue/IOS-869/tasksink-causes-occasional-crash-on-microphonechecker
📝 Summary
TaskSinkcauses an occasional crash on MicrophoneChecker. This revision attempts to fix this by holding a reference to the input value inside TaskSync and then use the hold value inside the async operation.☑️ Contributor Checklist