Skip to content

Use fmin and fmax for partial instead of 3' and 5'#2646

Merged
garrettjstevens merged 1 commit into
developfrom
correction_for_partial
May 10, 2022
Merged

Use fmin and fmax for partial instead of 3' and 5'#2646
garrettjstevens merged 1 commit into
developfrom
correction_for_partial

Conversation

@garrettjstevens

Copy link
Copy Markdown
Contributor

In an email from a user, they stated:

...we have noticed a problem with the ‘Partial’ field in the Apollo annotation editor that manifests when a gff file is created for a gene model.

The current UI stores the value of 3' as fmin_partial, and 5' as fmax_partial, which is incorrect, it should be the opposite. Also fmin_partial and fmax_partial are relative to the reference sequence, not the feature on its strand which might be what the annotator expects (so its ambiguous).

From what I can tell, the "partial" feature in Apollo is based on a similar feature in Artemis, see here. Artemis appears to use 5' and 3' relative to the feature on the strand, though, and Apollo does not, so I think all the above observations are correct.

After discussion with the user, we decided to change the checkboxes in the UI to say "fmin" and "fmax" instead of 3' and 5'. This accurately describes how Apollo handles the data internally, and is not ambiguous.

Before:
image

After:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant