Use Arrow IO and memory API for better performance - #110
Merged
Conversation
marcin-krystianc
force-pushed
the
dewv-20260506-perf
branch
from
May 8, 2026 12:36
8c030a6 to
6f0b33a
Compare
marcin-krystianc
force-pushed
the
dewv-20260506-perf
branch
from
May 15, 2026 14:01
4b8244a to
51ae6d8
Compare
marcin-krystianc
marked this pull request as ready for review
May 15, 2026 14:38
adamreeve
previously approved these changes
May 15, 2026
adamreeve
left a comment
Contributor
There was a problem hiding this comment.
Looks good thanks Marcin, just noticed a minor typo
Co-authored-by: Adam Reeve <adam.reeve@gr-oss.io>
adamreeve
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fstream,ofstream,fopen/fread,ostringstream) and memory (std::vector<uint8_t>) with Arrow equivalents (arrow::io::ReadableFile,arrow::io::FileOutputStream,arrow::io::BufferOutputStream,arrow::ResizableBuffer)ostringstream::str() + memcpyintovector<char>is now a singleBufferOutputStream::Finish())arrow::Bufferdirectly instead ofstd::vector<char> + memoryview