go.mod: bump golang.org/x/crypto to v0.52.0 (GO-2026-5018, reachable via agessh) - #736
Draft
Portll wants to merge 1 commit into
Draft
go.mod: bump golang.org/x/crypto to v0.52.0 (GO-2026-5018, reachable via agessh)#736Portll wants to merge 1 commit into
Portll wants to merge 1 commit into
Conversation
govulncheck (symbol level) reports GO-2026-5018 reachable through golang.org/x/crypto/ssh (NewSignerFromKey, via the SSH recipient support). It is fixed in x/crypto v0.52.0; this bumps 0.45.0 -> 0.52.0 and the tree scans clean afterward. Note: x/crypto v0.52.0 requires go >= 1.25, so this raises the module's go directive from 1.24.0 to 1.25.0. go mod tidy also moves x/sys and x/term to their matching releases. go build/vet and the full test suite pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
govulncheck(symbol level) reports GO-2026-5018 reachable in this codebase throughgolang.org/x/crypto/ssh—NewSignerFromKey, via the SSH recipient support inagessh. It is fixed ingolang.org/x/cryptov0.52.0; this bumps 0.45.0 → 0.52.0, andgovulncheck ./...reports the tree clean afterward.Heads-up on the
godirective: x/crypto v0.52.0 requiresgo >= 1.25, so this raises the module's directive fromgo 1.24.0togo 1.25.0. If holding the 1.24 floor matters more than closing this advisory right now, that's a reasonable call to make — flagging it rather than burying it.go mod tidyalso movesx/sysandx/termto their matching releases.Verification
go build ./...go vet ./...go test ./...— all packages passgovulncheck ./...reports no findings after the bumpOpened as a draft; the
goversion implication is the maintainer's call.