Skip to content

Properly implement FancyNames feature for solution generator - #455

Merged
ITaluone merged 1 commit into
Fallout-build:mainfrom
ITaluone:feat/fancy-names-source-gen
Jul 7, 2026
Merged

Properly implement FancyNames feature for solution generator#455
ITaluone merged 1 commit into
Fallout-build:mainfrom
ITaluone:feat/fancy-names-source-gen

Conversation

@ITaluone

Copy link
Copy Markdown
Contributor

Closes: #445

@ITaluone
ITaluone requested a review from a team as a code owner June 30, 2026 10:58
@ITaluone ITaluone added enhancement New feature or request target/vCurrent Targets the current version labels Jun 30, 2026
@ITaluone
ITaluone force-pushed the feat/fancy-names-source-gen branch from f0adab5 to 179f557 Compare June 30, 2026 11:07
@ChrisonSimtian
ChrisonSimtian requested a review from a team July 1, 2026 01:41
@ChrisonSimtian

Copy link
Copy Markdown
Collaborator

there is a bunch of generated files in *.Tests where they'd probably should be in *.Specs

Comment thread src/Fallout.SourceGenerators/StronglyTypedSolutionGenerator.cs
Comment thread src/Fallout.SourceGenerators/StronglyTypedSolutionGenerator.cs Outdated
@ITaluone
ITaluone force-pushed the feat/fancy-names-source-gen branch 6 times, most recently from e129592 to 17c3e77 Compare July 1, 2026 08:10
@ITaluone

ITaluone commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

there is a bunch of generated files in *.Tests where they'd probably should be in *.Specs

Ahh yes.. these were the old snapshots

@ITaluone
ITaluone requested a review from ChrisonSimtian July 1, 2026 08:15
@ITaluone
ITaluone force-pushed the feat/fancy-names-source-gen branch from 17c3e77 to 64bde45 Compare July 1, 2026 13:20
@dennisdoomen
dennisdoomen self-requested a review July 4, 2026 11:00
@ChrisonSimtian ChrisonSimtian added Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved and removed target/vCurrent Targets the current version labels Jul 7, 2026
@ITaluone
ITaluone enabled auto-merge (rebase) July 7, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Solution] FancyNames option is dead code

2 participants