Allow UTF-8 console input - #425
Conversation
ChrisonSimtian
left a comment
There was a problem hiding this comment.
generally lgtm, might be good to pull this into a IsValidInputKey() extension and put some unit tests around it
dennisdoomen
left a comment
There was a problem hiding this comment.
Can you extend the description a bit? What is it solving? Any chance for some test coverage?
|
I was just "backporting" a fix from the original repo, which I thought it would be useful*. Like the original description says: It previously wasn't allowed to have e.g. cyrillic letters as console input. Nothing more, nothing less :) *) I think we should port over fixes propagated by other NUKE contributors to let them know about this one. |
On to it |
56fc6fc to
7263df1
Compare
|
can we dial this one back a bit, please? Im all for the interface and such but I think this should be a smaller PR just for the UTF support. We can introduce interfaces and refactor this later :-) |
|
Ok.. but I don't get it.. you asked for unit tests.. and these are the changes to do so? Edit: done |
7263df1 to
1f5c763
Compare
ChrisonSimtian
left a comment
There was a problem hiding this comment.
way better :-) This way the blast radius is a bit smaller. And we hold off with the bigger refactoring a bit, I'm cooking something in behind the scenes that might make the refactoring obsolete ;-)
1f5c763 to
c7dd8e7
Compare
Move the valid console key check into an extension and add test cases All credits going to: @rus-art Taken from here: nuke-build/nuke#1321
c7dd8e7 to
68651af
Compare
Original description
All credits going to: @rus-art Thank you!
Taken from here: nuke-build/nuke#1321