fix #432 don't compare when object kind doesn't match kind in last-ap… - #542
Merged
Conversation
…plied-configuration Co-authored-by: Ryan <ryanisfluffy@users.noreply.github.com>
Fairwinds Insights Scan ResultsView the full report at insights.fairwinds.com. ✅ No new Action Items detected! |
sudermanjr
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…plied-configuration
This PR fixes #432
Checklist
Description
What's the goal of this PR?
Some objects, like controllerrevisions, were being reported as daemonsets with deprecated apiVersions. This PR prevents that.
What changes did you make?
Created a condition that looks for any objects where the object kind does not match the kind in the last-applied-configuration metadata. If true, excludes the object from the list of objects with deprecated api versions.
What alternative solution should we consider, if any?