Skip to content

Logging improvements #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FabrizioSandri merged 21 commits into from
Jul 26, 2022
Merged

Logging improvements #9

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
593acf4
deepstate_datatype_check rewritten
FabrizioSandri Jul 4, 2022
d42efaf
no need to use an else-if. Avoid to call deepstate_datatype_check twice
FabrizioSandri Jul 4, 2022
9a44dfb
return the mismatched datatypes
FabrizioSandri Jul 4, 2022
0b4d2d9
print the list of mismatched datatypes
FabrizioSandri Jul 4, 2022
ad4bf24
removed unused code
FabrizioSandri Jul 5, 2022
b012edb
no need to import RInside
FabrizioSandri Jul 5, 2022
f76a7e1
verbose parameter
FabrizioSandri Jul 6, 2022
df138c9
roxygen documentation update
FabrizioSandri Jul 6, 2022
72f564b
documentation files
FabrizioSandri Jul 6, 2022
f516aa0
Setup CI checks for this branch
FabrizioSandri Jul 6, 2022
1d7e9cc
list_testfiles brackets fix
FabrizioSandri Jul 8, 2022
91da805
mismatched datatypes fix
FabrizioSandri Jul 8, 2022
6b85147
workflow run on every branch
FabrizioSandri Jul 8, 2022
1c33720
mismatched datatypes improvement
FabrizioSandri Jul 8, 2022
8efdebc
rename deepstate_get_unsupported_datatypes
FabrizioSandri Jul 11, 2022
e8a1a60
deepstate_fun_create improvements - table
FabrizioSandri Jul 11, 2022
22def71
data table update
FabrizioSandri Jul 12, 2022
aa8639d
verbose parameter fix
FabrizioSandri Jul 18, 2022
7b4d7e9
code refactoring
FabrizioSandri Jul 23, 2022
95c3d88
analyze binary parameters fix
FabrizioSandri Jul 26, 2022
cda836b
run CI only once fix
FabrizioSandri Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions R/get-pkgs.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,9 @@ deepstate_get_mismatched_datatypes <- function(params.list){
params.list <-gsub(" ","",params.list)
datatypes <- list("NumericVector","NumericMatrix" ,"arma::mat","double",
"string","CharacterVector","int","IntegerVector")

@tdhock tdhock Jul 8, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the list of supported data types right? So rather than "mismatched" in the function name maybe "unsupported" would be more appropriate?
Also this list is redundant with the logic in https://github.com/FabrizioSandri/RcppDeepState/blob/master/R/fun_harness_create.R -- if you have time it would be good to reorganize that code so that a list or table is used to lookup what to do, rather than the current code which is rather difficult to understand (lots of if/else statements).

@FabrizioSandri FabrizioSandri Jul 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, this list is redundant. I updated the deepstate_fun_create function inside fun_harness_create.R and replaced the if else statements with a table containing information for the supported datatypes. In detail each column of this table corresponds to a supported datatype and provides some details on it. The first row of this table contains an alternative datatype to be used when saving the inputs(e.g., using qs::c_qsave), whereas the second row correspond to the associated generation function that takes as input a range. When a datatype contains a value of NA in both rows, it means that is supported, utilizes itself when executing qs::c_qsave and lacks a range function. In this way checking if a datatype is supported is really simple: just check if exists a column for the datatype in this table.

@FabrizioSandri FabrizioSandri Jul 11, 2022

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the function deepstate_get_unsupported_datatypes may now be removed.

mismatched_datatypes <- list()
matched <- params.list %in% datatypes
if (!all(matched)){
mismatched_datatypes <- params.list[!matched]
}

mismatched_datatypes
matched <- params.list %in% datatypes
mismatched_datatypes <- params.list[!matched]

}

Expand Down