Say why imaging failed, not just that it did

[mastacontrola]

TaskError has been sending ImageName and Reason on HOST_IMAGE_FAIL since the FOS reporting work landed — Reason being the flattened, MAX_REASON-bounded opening of whatever FOS actually reported. Both bundled listeners ignored all of it and pushed the fixed string This host has failed to image.

Found while doing the end-to-end live test of the FOS report path on 1.6. A report whose stored row reads

fog.download: failed to restore partition 2
  partclone.ntfs: /dev/sda2 is busy
  ERROR: win11-split part 2 checksum mismatch
  exit code 1 (fog.download)

produced a push saying, in its entirety, fos-deploy-test Failed / This host has failed to image. So the whole point of storing the trace — somebody seeing it — stopped at the server.

	before	after
slack	Host: lab01 imaging failed.	Host lab01 failed imaging Win11-Lab: fog.download: failed to restore partition 2 …
pushbullet	lab01 Failed / This host has failed to image	lab01 Imaging Failed / This host failed imaging Win11-Lab: fog.download: …

Defensive about every added key

These events fire only when something has already gone wrong, and a web tree can be older than whatever writes the payload. A bare $data['Reason'] would turn the notification into a PHP warning at the worst possible moment:

$reason = (string) ($data['Reason'] ?? '');
if ('' === $reason) {
    $reason = _('no reason was reported');
}

Both keys fall back to a translated placeholder rather than an empty slot, so an older server says failed imaging an unnamed image: no reason was reported instead of failed imaging : .

Translation

The substitution happens outside _(), with positional specifiers. A msgid built at runtime matches no catalog entry and never translates — silently and permanently — and %1$s lets a translator reorder the sentence.

Slack's old form had 'Host: %s ' outside the call and translated only the tail (_('imaging failed.')), which is not a sentence anyone could translate. That is now one whole msgid.

Relationship to 1.6

Ported from FOGProject/fog-plugins#21, which did the same for the 1.6 line, where these plugins now live as a pinned release asset. ntfy has no listener on this branch, so this is two files rather than three.

⚠️ The 1.6 side is merged but unreleased — fog-plugins main carries #21, the latest release v1.6.10 predates it, and FOG_PLUGINS_VERSION still pins v1.6.10. A v1.6.11 release and a pin bump are needed for 1.6 servers to get this; that is not part of this PR.

Verification

tests/imaging-failure-reason.test.php pins the reads, the defaults, the fallbacks and the gettext shape. Source-level, because these classes extend the plugin's Event base, which extends FOG's, so neither loads without a booted FOG, a session and a database.

Six mutations, all killed — and each confirmed to have actually applied to the file, rather than a no-op regex reading as a pass:

stop reading Reason              -> never reads Reason
read Reason with no default      -> read without a default
interpolate inside _()           -> msgid built at runtime
drop the missing-reason default  -> renders with an empty slot
bare %s instead of %1$s          -> translator cannot reorder
stop naming the image            -> never names the image

Full suite: 15 passed, 0 failed.

🤖 Generated with Claude Code

https://claude.ai/code/session_013mJVe4CpK3rRbi9H5GubXd