Fixed issue where websocket hook did not call original completion#609
Merged
NSExceptional merged 1 commit intoAug 10, 2022
Conversation
Contributor
Author
|
@NSExceptional could you have a look at this one? |
NSExceptional
requested changes
Aug 10, 2022
NSExceptional
left a comment
NSExceptional
left a comment
Collaborator
There was a problem hiding this comment.
Nice catch, thank you! Also, sorry, I must have totally missed this PR. Thanks for pinging me.
Check for completion nullability
Contributor
Author
I've added nullability check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send message hook was changing original completion instead of wrapping it in a hook.
Similar hook already exists for receivemessage functionality, but it was not working for send-message, original completion was never called.
Adjusted code to create a new completionHook which records the information and then original completion block.
I also updated API-Key for piesocket and added a message after sending message, to make sure that completion is being called and at least success/failure message is logged.