Skip to content

Create new getReadQueryCount acessor#2686

Closed
Valforte wants to merge 4 commits into
mainfrom
valforte/getReadQueryCount
Closed

Create new getReadQueryCount acessor#2686
Valforte wants to merge 4 commits into
mainfrom
valforte/getReadQueryCount

Conversation

@Valforte

Copy link
Copy Markdown
Contributor

Details

Add a new acessor getReadQueryCount so we can count the number of read queries a test does using db.getReadQueryCount in an Auth test.

Fixed Issues

Requirement to fix https://github.com/Expensify/Expensify/issues/659611

Tests

Compiled everything and ran all Auth tests


Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

@Valforte Valforte self-assigned this Jul 17, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8a8cc44899

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread test/lib/RemoteSQLite.cpp Outdated
@Valforte
Valforte requested a review from a team July 17, 2026 16:42
@melvin-bot
melvin-bot Bot requested review from deetergp and removed request for a team July 17, 2026 16:43

@flodnv flodnv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flodnv flodnv closed this Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants