This repository was archived by the owner on Aug 1, 2025. It is now read-only.
Update example platforms with Apple silicon support#24
Merged
EverlastingBugstopper merged 2 commits intoMay 3, 2023
Merged
Conversation
maxdeviant
commented
Aug 11, 2022
| run(fetchOptions) { | ||
| if (!this.exists()) { | ||
| this.install(fetchOptions, true) | ||
| this.install(fetchOptions, true); |
Author
There was a problem hiding this comment.
This was a Prettier change; it looks like main is currently failing the Prettier check:
λ nix-shell -p nodejs --command "npm run fmt:check"
> fmt:check
> prettier --check **/**/*.js
Checking formatting...
packages/binary-install/index.js
Code style issues found in the above file(s). Forgot to run Prettier?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the supported platforms in the
binary-install-exampleto include support for Apple silicon.Since we don't currently build binaries for Apple silicon we're just using the
x86_64-apple-darwintarget triple, which will then get run through Rosetta 2. This is the same thing that Rover currently does.