This repository was archived by the owner on Aug 1, 2025. It is now read-only.
Fix log suppression#23
Merged
EverlastingBugstopper merged 2 commits intoMay 4, 2023
Merged
Conversation
maxdeviant
commented
Aug 11, 2022
|
@EverlastingBugstopper Hey, would you be able to merge this PR and cut a new release, please? |
EverlastingBugstopper
approved these changes
May 3, 2023
EverlastingBugstopper
left a comment
EverlastingBugstopper
left a comment
Owner
There was a problem hiding this comment.
Thanks for the fix!
Owner
|
@maxdeviant - I just pushed some updates to the repo and tests/lints are now passing on |
Author
Sure thing! |
Author
|
@EverlastingBugstopper All pushed and ready to go 😄 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some instances of logs not being suppressed.
The usage of the
suppressLogsflag was actually inverted, withsuppressLogs = truecausing the logs to be written andsuppressLogs = falsecausing the logs to be suppressed.