Check the different API version usages#4983
Open
hornokattila wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #3276: Check the different API version usages
Adds inline documentation explaining the MAJOR.MINOR versioning strategy used across the codebase, and standardizes the one place where version parsing was not explicitly constrained to two components.
Changes
web/codechecker_web/shared/version.py— Added module docstring documenting the versioning scheme and how version flows through the system.web/server/codechecker_server/routing.py— Clarifiedis_supported_version()docstring re: why trailing version components are discarded.web/server/codechecker_server/api/report_server.py— Documented the backward-compat branching logic; changed version parsing to explicitly take only major.minor (prevents accidental 3-part tuple comparisons).web/server/vue-cli/config/webpack.common.js— Added comment explaining why the npm semver patch is stripped.