Skip to content

Try: Use github.actor as default value for commit author - #128

Merged
EndBug merged 2 commits into
EndBug:masterfrom
ocean90:try/github-actor
Jan 16, 2021
Merged

Try: Use github.actor as default value for commit author#128
EndBug merged 2 commits into
EndBug:masterfrom
ocean90:try/github-actor

Conversation

@ocean90

@ocean90 ocean90 commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

With regards to #126 and #125 I was wondering if we can't use a better default value. Looking at the docs I found github.actor in the GitHub context which is "The login of the user that initiated the workflow run" which is basically the committer name.

Some actions/workflows are already using this:

The PR is currently untested, open for discussion, and needs some sanity checks.

The current API request was added in #49 for PR support.

@EndBug EndBug added status: pending More info is needed before deciding what to do type: feature New feature or feature request labels Jan 5, 2021
@ocean90

ocean90 commented Jan 8, 2021

Copy link
Copy Markdown
Contributor Author

I have used the forked action in a private repo and it's working fine so far.

@EndBug

EndBug commented Jan 11, 2021

Copy link
Copy Markdown
Owner

Sorry if I couldn't take a look at this before.
I have a question: what if I manually trigger the workflow on a commit by someone else? The current action would pick the commit author, while your change would look at me, since I'm the one that started the run. Am I right?

@ocean90

ocean90 commented Jan 11, 2021

Copy link
Copy Markdown
Contributor Author

That's correct. I think this is a better behavior than before?

@EndBug

EndBug commented Jan 11, 2021

Copy link
Copy Markdown
Owner

Seems fair
As soon as I'll be able to test this it will be added as a major change then 👍🏻

@EndBug
EndBug merged commit 9c05614 into EndBug:master Jan 16, 2021
@EndBug

EndBug commented Jan 16, 2021

Copy link
Copy Markdown
Owner

@all-contributors please add @ocean90 for their code

@allcontributors

Copy link
Copy Markdown
Contributor

@EndBug

I've put up a pull request to add @ocean90! 🎉

@EndBug

EndBug commented Jan 16, 2021

Copy link
Copy Markdown
Owner

Introduced in v7.0.0 (v7, latest)

Thanks for the PRs!

@ocean90
ocean90 deleted the try/github-actor branch January 18, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: pending More info is needed before deciding what to do type: feature New feature or feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants