Try: Use github.actor as default value for commit author - #128
Merged
Conversation
Contributor
Author
|
I have used the forked action in a private repo and it's working fine so far. |
Owner
|
Sorry if I couldn't take a look at this before. |
Contributor
Author
|
That's correct. I think this is a better behavior than before? |
Owner
|
Seems fair |
Owner
|
@all-contributors please add @ocean90 for their code |
Contributor
|
I've put up a pull request to add @ocean90! 🎉 |
Owner
|
Introduced in Thanks for the PRs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With regards to #126 and #125 I was wondering if we can't use a better default value. Looking at the docs I found
github.actorin the GitHub context which is "The login of the user that initiated the workflow run" which is basically the committer name.Some actions/workflows are already using this:
The PR is
currently untested,open for discussion, and needs some sanity checks.The current API request was added in #49 for PR support.