GHA CI migration#1553
Conversation
tomt1664
force-pushed
the
gha_ci_migration
branch
2 times, most recently
from
7814a9d to
a1cb489
Compare
|
Seeing a failure on the macos 13 task which looks git related, not sure if that's what's stopping the other tasks from running? |
tomt1664
force-pushed
the
gha_ci_migration
branch
from
a1cb489 to
9b065d5
Compare
|
Squashed all the commits. The failure seems to be due to the Merge base branch step which apparently not be needed with actions/checkout@v4 |
tomt1664
force-pushed
the
gha_ci_migration
branch
from
afdeecb to
9cd01a1
Compare
|
All jobs should now pass.
|
tomt1664
force-pushed
the
gha_ci_migration
branch
from
9cd01a1 to
9247676
Compare
delta1
left a comment
delta1
left a comment
There was a problem hiding this comment.
Left a few comments, nothing major
| if: ${{ (github.event_name == 'push') && (github.ref_name == github.event.repository.default_branch) && (env.previous-releases-cache-hit != 'true' )}} | ||
| with: | ||
| path: ${{ env.PREVIOUS_RELEASES_DIR }} | ||
| key: previous-releases-${{ env.CONTAINER_NAME }}-${{ env.PREVIOUS_RELEASES_HASH }} |
There was a problem hiding this comment.
configure-docker, configure-environment, restore-caches, and save-caches are never referenced in ci.yml. Are they necessary? Caching seems to be covered by actions/cache/save and restore?
| runs-on: ${{ github.repository == 'ElementsProject/elements' && fromJSON('["self-hosted","linux","x64"]') || 'ubuntu-latest' }} | ||
| timeout-minutes: 180 | ||
| env: | ||
| FILE_ENV: "./ci/test/00_setup_env_native_msan.sh" |
There was a problem hiding this comment.
Does this job not also need to exclude feature_proxy and feature_bind ?
|
|
||
| # ------------------------------------------------------------------------- | ||
| # Win64 native MSVC - Short running functional tests | ||
| # Runner: windows-2019 (has VS 2019, equivalent to cirrusci/windowsservercore:visualstudio2019) |
There was a problem hiding this comment.
nit: The windows 2019 comments are outdated now
| # Win64 native MSVC - Short running functional tests | ||
| # Runner: windows-2019 (has VS 2019, equivalent to cirrusci/windowsservercore:visualstudio2019) | ||
| # ------------------------------------------------------------------------- | ||
| win64-msvc-short: |
There was a problem hiding this comment.
win64-msvc-short and win64-msvc-long repeat identical Qt build, vcpkg install, Python install, and MSVC build steps. It would be nice to extract these into a common reusable workflow to remove the duplication, but this can be done in a follow-up
There was a problem hiding this comment.
I might as well combine them now - time limit on GHA is 6 hours.
| export RUN_UNIT_TESTS=false | ||
| export RUN_FUNCTIONAL_TESTS=false | ||
| export GOAL="" | ||
| export BITCOIN_CONFIG="" No newline at end of file |
There was a problem hiding this comment.
nit: needs a newline at end of file
|
Just waiting on CI to finish |
2 participants
Migration of Elements CI from Cirrus (which is closing 1st June) to Github actions.
Notes:
GHA runners have IPV6 disabled in their linux containers. So
feature_proxy.pyandrpc_blind.py --ipv6disabled for these, as in bitcoin/bitcoin#30193windows-2019is being deprecated and no runners appear to be readily available. actions/runner-images#12045 (consider changing towindows-2022) forwin64-msvcjobs.previous-releasesrequires a persistent self-hosted runner. This job was being skipped by Cirrus (withNo public persistent worker pools found!).