Skip to content

bug(#18456) in popconfirm onConfirm/onCancel fixed - #18457

Closed
itsjithinv wants to merge 1 commit into
ElemeFE:devfrom
itsjithinv:hotfix/popconfirm-callback-events
Closed

bug(#18456) in popconfirm onConfirm/onCancel fixed #18457
itsjithinv wants to merge 1 commit into
ElemeFE:devfrom
itsjithinv:hotfix/popconfirm-callback-events

Conversation

@itsjithinv

@itsjithinv itsjithinv commented Dec 18, 2019

Copy link
Copy Markdown

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@itsjithinv itsjithinv changed the title bugs in popconfirm onConfirm/onCancel fixed bug(#18456) in popconfirm onConfirm/onCancel fixed Dec 18, 2019
@element-bot

Copy link
Copy Markdown
Member

Deploy preview for element ready!

Built with commit 2f21e62

https://deploy-preview-18457--element.netlify.com

@oleksiikhr

Copy link
Copy Markdown
Contributor

These 2 PR would be join into one :)
#18324

@oleksiikhr

Copy link
Copy Markdown
Contributor

#18456

@praveenpuglia

Copy link
Copy Markdown

Thanks. Just came here to see if a PR for this already exists otherwise I would have submitted one. It has caused me a bunch of hours.

@iamkun

iamkun commented Oct 29, 2020

Copy link
Copy Markdown
Member

Now fixed to the correct 'confirm' and 'cancel' event name in #20240

@iamkun iamkun closed this Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants