Skip to content

CascaderPanel: fix bug in parent node and child node have the same value on lazy load mode - #16809

Closed
EHfive wants to merge 1 commit into
ElemeFE:devfrom
EHfive:fix-cascader-lazy-load
Closed

CascaderPanel: fix bug in parent node and child node have the same value on lazy load mode#16809
EHfive wants to merge 1 commit into
ElemeFE:devfrom
EHfive:fix-cascader-lazy-load

Conversation

@EHfive

@EHfive EHfive commented Jul 30, 2019

Copy link
Copy Markdown

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

relative PRs: #15935 #16420

@element-bot

element-bot commented Jul 30, 2019

Copy link
Copy Markdown
Member

Deploy preview for element ready!

Built with commit 4861fdb

https://deploy-preview-16809--element.netlify.com

@EHfive
EHfive force-pushed the fix-cascader-lazy-load branch from 9ec8e79 to 54e8805 Compare July 30, 2019 15:01
@EHfive
EHfive force-pushed the fix-cascader-lazy-load branch from 54e8805 to 4861fdb Compare July 30, 2019 15:05
@EHfive

EHfive commented Jul 30, 2019

Copy link
Copy Markdown
Author

#15935 使 Store.prototype.getNodeByValue(value)value可以匹配node.path获取Node解决了父子node.value重复问题

#16809 由于传入 Store.prototype.getNodeByValue(value) 的value不是路径, 使父子value相同会导致回显失败

@ziyoung

ziyoung commented Jul 31, 2019

Copy link
Copy Markdown
Contributor

请提供个 demo。

@EHfive

EHfive commented Jul 31, 2019

Copy link
Copy Markdown
Author

@stale

stale Bot commented Jul 30, 2020

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Jul 30, 2020
@EHfive

EHfive commented Jul 30, 2020

Copy link
Copy Markdown
Author

Still in v2.13.2

https://codepen.io/ehfive/pen/NWxZYXm

@stale stale Bot removed the stale label Jul 30, 2020
@stale

stale Bot commented Aug 21, 2021

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Aug 21, 2021
@EHfive

EHfive commented Aug 21, 2021

Copy link
Copy Markdown
Author

Still in v2.15.5, https://codepen.io/ehfive/pen/NWxZYXm (same URL as above).

The PR seems can still be applied. But I am not sure if I got enough energy to following up on the PR.

@stale stale Bot removed the stale label Aug 21, 2021
@EHfive EHfive closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants