Skip to content

Pass the "--names" option to PHPCPD.#192

Closed
beerendlauwers wants to merge 2 commits into
EdgedesignCZ:masterfrom
beerendlauwers:master
Closed

Pass the "--names" option to PHPCPD.#192
beerendlauwers wants to merge 2 commits into
EdgedesignCZ:masterfrom
beerendlauwers:master

Conversation

@beerendlauwers

Copy link
Copy Markdown

Addresses #170.

@zdenekdrahos

zdenekdrahos commented Dec 3, 2019

Copy link
Copy Markdown
Member

It might be better to use phpqa.extensions just like in the other tools. The extensions are already documented and you don't have to define extensions twice. What do you think?

$phpcpdNames = array_map(
    function ($extension) {
        return "*.{$extension}";
    },
    explode(',', $this->config->csv('phpqa.extensions'))
);
// ...
names' => implode(',', $phpcpdNames),

@beerendlauwers

Copy link
Copy Markdown
Author

Good point. Refactored.

Comment thread src/Tools/Analyzer/Phpcpd.php Outdated
Co-Authored-By: Zdeněk Drahoš <drahoszdenek@gmail.com>
@zdenekdrahos

Copy link
Copy Markdown
Member

Fixed in #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants