Phpstan no longer depends on nette/neon

[ndench]

Phpstan has moved it's development to phpstan/phpstan-src, and phpstan/phpstan is just a phar install. This means that it no longer depends on nette/neon.

The [Phpstan Analyser] uses nette/neon to process phpstan config, which now results in an error:

ERROR: Uncaught Error: Class 'Nette\Neon\Neon' not found in vendor/edgedesign/phpqa/src/Tools/Analyzer/Phpstan.php:32 

I think we have a few options to resolve this:

1. Require nette/neon in phpqa -> this means that users who don't want phpstan still must install it
2. Make users who want to use phpstan require nette/neon -> solves the problem, that's what I'm doing now but it is a bit annoying
3. Update the phpstan analyser to not create dynamic config -> other analysers are not creating dynamic config so I'm unsure as to why phpstan is

Personally I prefer option 3, but I'm open to the others as well. I'm happy to do the work for this if we can agree on the way forward.

[zdenekdrahos]

ad 1) phpqa won't preinstall dependencies for suggested tools.

ad 2) It's already fixed (#194), if you are using bin/suggested-tools.sh.
You must install neon, even if you add notice to composer.json, refine an error message etc. It's annonying, but it's the only way for suggested tool.

composer require phpstan/phpstan:~0.12.0 nette/neon

ad 3) Can you exclude files without config file? Or any other more advanced config? I don't think so.

[ndench]

That is for the speedy fox @zdenekdrahos, I think option 2 is the easiest and most effective one 👍.