Call coord.core_bounds() instead of coord.bounds in check.py - #2146
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2146 +/- ##
=======================================
Coverage 93.09% 93.09%
=======================================
Files 237 237
Lines 12795 12795
=======================================
Hits 11911 11911
Misses 884 884
|
valeriupredoi
approved these changes
Jul 25, 2023
valeriupredoi
left a comment
valeriupredoi
left a comment
Contributor
There was a problem hiding this comment.
nice one, cheers @sloosvel 🍺
bouweandela
added
cmor
zklaus
added
cmor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR avoids the realisation of bounds for auxiliary coordinates, by calling coord.core_bounds() instead of coord.bounds()
Closes #2145
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
- [x] 🧪 and 🛠 Documentation is available- [ ] 🛠 Unit tests have been added- [ ] 🛠 Any changed dependencies have been added or removed correctlyTo help with the number pull requests: