feat(charts): policy to enable authenticated workflows#1414
Open
davehadley wants to merge 1 commit into
Open
Conversation
davehadley
force-pushed
the
drh/inject-auth-daemon-into-workflows-2
branch
3 times, most recently
from
310aab4 to
9e02149
Compare
davehadley
force-pushed
the
drh/inject-auth-daemon-into-workflows-2
branch
from
9e02149 to
d9ee825
Compare
TBThomas56
reviewed
Jun 26, 2026
| spec: | ||
| entrypoint: entry | ||
| templates: | ||
| - name: entry |
Contributor
There was a problem hiding this comment.
I think that while we are testing this, could it be worth running having both templates instead of deleting the current one?
TBThomas56
reviewed
Jun 26, 2026
| parameters: | ||
| - name: cmd | ||
| value: | | ||
| curl -v --request POST ${GRAPH_URL} -H "Content-Type: application/json" -d '{"query": "mutation{ submitWorkflowTemplate(name: \"conditional-steps\", visit: {proposalCode: \"ks\", proposalNumber: 10000, number: 1}, parameters: {}){ name } }" }' |
Contributor
There was a problem hiding this comment.
How does curling this command to the graph intiate auth-daemon. the reason why we curl auth-daemon is so that it can forward that request while refreshing the token
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is incremental progress towards https://jira.diamond.ac.uk/browse/AP-1176
Further changes are needed to https://github.com/DiamondLightSource/workflows/blob/main/charts/workflows/templates/auth-daemon-config-clusterpolicy.yaml
but I would like have this reviewed and merged in now.
It is locked behind a feature flag and only deployed to staging.