Skip to content

feat: Add OpaClient to wrap auth checks#1541

Merged
tpoliaw merged 6 commits into
mainfrom
opa-client
Jun 23, 2026
Merged

feat: Add OpaClient to wrap auth checks#1541
tpoliaw merged 6 commits into
mainfrom
opa-client

Conversation

@tpoliaw

@tpoliaw tpoliaw commented May 15, 2026

Copy link
Copy Markdown
Contributor

Proof of concept opa client with dependency injection and example check

@tpoliaw tpoliaw changed the title feat: Add OpaClient to wrap auth checks" feat: Add OpaClient to wrap auth checks May 15, 2026
Comment thread src/blueapi/service/main.py Fixed
@tpoliaw tpoliaw force-pushed the opa-client branch 2 times, most recently from e8ddc77 to db3325b Compare May 15, 2026 15:31
@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.84%. Comparing base (36f077c) to head (f048b05).

Additional details and impacted files
@@               Coverage Diff                @@
##           depends-user    #1541      +/-   ##
================================================
+ Coverage         95.70%   95.84%   +0.13%     
================================================
  Files                43       44       +1     
  Lines              3240     3276      +36     
================================================
+ Hits               3101     3140      +39     
+ Misses              139      136       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw tpoliaw force-pushed the opa-client branch 2 times, most recently from 8f83ef8 to 5c3dba8 Compare May 29, 2026 10:49
@tpoliaw tpoliaw changed the base branch from main to depends-user May 29, 2026 10:50
@tpoliaw tpoliaw marked this pull request as ready for review June 2, 2026 11:13
@tpoliaw tpoliaw requested a review from a team as a code owner June 2, 2026 11:13

@fajinyuan fajinyuan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my questions.

Comment thread src/blueapi/config.py
Comment thread helm/blueapi/values.schema.json

@ZohebShaikh ZohebShaikh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Comment thread src/blueapi/service/authorization.py Outdated
Comment thread src/blueapi/service/authorization.py Outdated
Comment thread src/blueapi/service/authorization.py Outdated
Comment thread src/blueapi/service/authorization.py
Comment thread src/blueapi/config.py
@tpoliaw tpoliaw force-pushed the opa-client branch 3 times, most recently from 5e8af18 to 0374da6 Compare June 8, 2026 20:05
@ZohebShaikh ZohebShaikh self-requested a review June 23, 2026 10:17
Base automatically changed from depends-user to main June 23, 2026 14:46
@tpoliaw tpoliaw added this pull request to the merge queue Jun 23, 2026
Merged via the queue into main with commit 7fe3fda Jun 23, 2026
34 checks passed
@tpoliaw tpoliaw deleted the opa-client branch June 23, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants