Lots of changes associated with structure of our project - #2
Open
doyonghoon wants to merge 7 commits into
Open
Conversation
Member
|
|
Member
|
You should add You can probably just append your current |
Contributor
Author
|
oh, I already added |
Member
|
@doyonghoon Oh I didn't see that! You seem to still be committing stuff in your .idea/ directory. The .gitignore will start working when you remove your .idea/ directory. EDIT: NEVERMIND IGNORE THIS |
Contributor
Author
|
i have merged commits left behind from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
BaseActivityandBaseFragmentto followDRYprinciple.MajorParserandUnivParserare replaced byApiProviderclass, however not removed from the package.This PR contains such additional libraries.
Gson: is a Java library that can be used to convert Java Objects into their JSON representation. It can also be used to convert a JSON string to an equivalent Java object.Retrofit: Type-safe HTTP client for Android.Butterknife: Field and method binding for Android views which uses annotation processing to generate boilerplate code for you.Glide: is a fast and efficient open source media management and image loading framework.