Skip to content

Lots of changes associated with structure of our project - #2

Open
doyonghoon wants to merge 7 commits into
parsingfrom
basic-structure
Open

Lots of changes associated with structure of our project#2
doyonghoon wants to merge 7 commits into
parsingfrom
basic-structure

Conversation

@doyonghoon

Copy link
Copy Markdown
Contributor

Changes

  • This PR leads to use BaseActivity and BaseFragment to follow DRY principle.
  • The app will load list of colleges from our server and shows on the screen by utilizing retrofit and gson.
  • MajorParser and UnivParser are replaced by ApiProvider class, however not removed from the package.

This PR contains such additional libraries.

  • Gson: is a Java library that can be used to convert Java Objects into their JSON representation. It can also be used to convert a JSON string to an equivalent Java object.
  • Retrofit: Type-safe HTTP client for Android.
  • Butterknife: Field and method binding for Android views which uses annotation processing to generate boilerplate code for you.
  • Glide: is a fast and efficient open source media management and image loading framework.

@doyonghoon doyonghoon self-assigned this Oct 29, 2015
@banhathome

Copy link
Copy Markdown
Member

basic-structure is a couple of commits behind parsing. You should rebase or merge to fix this

@banhathome

Copy link
Copy Markdown
Member

You should add .idea to .gitignore.

You can probably just append your current .gitignore with this: https://github.com/github/gitignore/blob/master/Global/JetBrains.gitignore

@doyonghoon

Copy link
Copy Markdown
Contributor Author

oh, I already added .idea to .gitignore L44-L64, is it not working for you?
@chrisngobanh

.idea/
# if you remove the above rule, at least ignore the following:

# User-specific stuff:
# .idea/workspace.xml
# .idea/tasks.xml
# .idea/dictionaries

# Sensitive or high-churn files:
# .idea/dataSources.ids
# .idea/dataSources.xml
# .idea/sqlDataSources.xml
# .idea/dynamic.xml
# .idea/uiDesigner.xml

# Gradle:
# .idea/gradle.xml
# .idea/libraries

# Mongo Explorer plugin:
# .idea/mongoSettings.xml

@banhathome

Copy link
Copy Markdown
Member

@doyonghoon Oh I didn't see that! You seem to still be committing stuff in your .idea/ directory. The .gitignore will start working when you remove your .idea/ directory.

EDIT: NEVERMIND IGNORE THIS

@doyonghoon doyonghoon self-assigned this Oct 29, 2015
@doyonghoon

Copy link
Copy Markdown
Contributor Author

i have merged commits left behind from parsing branch, now this PR is ready to be merged without any conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants