Fix build-profiling-ffi.sh script not working with relative paths + Fix incorrect placeholder for version#46
Merged
Merged
Conversation
This confused me a bit, since I had used it with relative paths in the past, and the fixed turned out to be quite trivial.
We're actually replacing `@Datadog_VERSION@` not `@DDog_VERSION@` in the `build-profiling-ffi.sh` script.
sanchda
approved these changes
Aug 30, 2022
sanchda
left a comment
sanchda
left a comment
Contributor
There was a problem hiding this comment.
Not bad! Fixes the problem without adding any new tools or drastically changing the build system. Thank you!
ivoanjo
pushed a commit
that referenced
this pull request
Jun 18, 2025
* Github CI lint and and tests * fix missing licenses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
build-profiling-ffi.shscript not working with relative pathsMotivation
See individual commit messages for details.
How to test the change?
build-profiling-ffi.shstill produces the same output as before, as well as working now with relative pathsdatadog_profiling_with_rpath.pcgets templated correctly with the version