Bump Rust version to 1.60#25
Merged
Merged
Conversation
ivoanjo
approved these changes
Jun 8, 2022
ivoanjo
left a comment
ivoanjo
left a comment
Member
There was a problem hiding this comment.
👍 LGTM
Should we also add the rust-version to Cargo.toml as discussed in https://blog.rust-lang.org/2021/10/21/Rust-1.56.0.html#cargo-rust-version ? That should help avoid any "oops wrong Rust version" issues :)
pawelchcki
approved these changes
Jun 8, 2022
morrisonlevi
approved these changes
Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Alpine released a new version including rust 1.60. We no longer need to build with rust 1.56.
Motivation
Build with newer version
Additional Notes
N/A
How to test the change?
CI