Skip to content

feat(otlp)!: Export OTLP spans with attribute-level OTel compatibility #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 12 commits into from
Jun 22, 2026
+276 −37
Merged

feat(otlp)!: Export OTLP spans with attribute-level OTel compatibility #2091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7332acb
feat(otel): Update the trace exporter with a OTel trace compatbility …
zacharycmontoya Jun 4, 2026
110a9ef
Fix dropped attributes count calculation toaccount for OTel Trace Com…
zacharycmontoya Jun 4, 2026
2d0d234
Update the DD span => OTLP span mapping to remove the 'error.msg' and…
zacharycmontoya Jun 5, 2026
2efa686
Run the linter
zacharycmontoya Jun 9, 2026
e86566e
Exclude the "span.kind" span attribute from being emitted on OTLP spa…
zacharycmontoya Jun 9, 2026
06a7212
Rename the config to `otel_trace_semantics_enabled`
zacharycmontoya Jun 12, 2026
91c8608
Fix linter issues
zacharycmontoya Jun 12, 2026
61a273f
Small comment update
zacharycmontoya Jun 12, 2026
d5827ff
Address PR feedback:
zacharycmontoya Jun 22, 2026
a597ed7
Merge branch 'main' into zach.montoya/otlp-compatibility-mode
zacharycmontoya Jun 22, 2026
1784bee
Fix lint issues
zacharycmontoya Jun 22, 2026
58af6e5
Fix callsites introduced from merging main
zacharycmontoya Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions libdd-data-pipeline/src/otlp/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ pub struct OtlpTraceConfig {
/// Protocol (for future use; currently only HttpJson is supported).
#[allow(dead_code)]
pub(crate) protocol: OtlpProtocol,
/// When `true`, does not add DD-specific per-span attributes to the OTLP payload.
// These attributes are: (`service.name`, `operation.name`, `resource.name`,
// `span.type`, `error.msg`, `error.message`, `span.kind`)
pub otel_trace_semantics_enabled: bool,
}

/// Parsed OTLP trace-metrics exporter configuration.
Expand Down
9 changes: 8 additions & 1 deletion libdd-data-pipeline/src/trace_exporter/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,13 @@ impl TraceExporterBuilder {
self
}

/// Strip Datadog-specific `dd.*`/`_dd.*` data-point attributes from the exported histogram.
/// Enables OTel trace semantics, which does not add DD-specific per-span attributes
/// (`service.name`, `operation.name`, `resource.name`, `span.type`, `error.msg`,
/// `error.message`, `span.kind`) to the OTLP payload.
/// Also strips Datadog-specific `dd.*`/`_dd.*` data-point attributes from the exported
/// histogram. This is useful when exporting to a native OTel backend that does not expect
/// Datadog semantics. The host language tracer is expected to observe this behavior by
/// setting the `DD_TRACE_OTEL_SEMANTICS_ENABLED` environment variable to `true`.
pub fn enable_otel_trace_semantics(&mut self) -> &mut Self {

@ekump ekump Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to add a corresponding function to the FFI API?

@zacharycmontoya zacharycmontoya Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll follow up and post a change to the FFI API as a separate PR, as this is only consumed in dd-trace-py for now

self.otel_trace_semantics_enabled = true;
self
Expand Down Expand Up @@ -488,6 +494,7 @@ impl TraceExporterBuilder {
headers: build_otlp_header_map(self.otlp_headers),
timeout: otlp_timeout,
protocol: OtlpProtocol::HttpJson,
otel_trace_semantics_enabled: self.otel_trace_semantics_enabled,
});

let otlp_metrics_config = self.otlp_metrics_endpoint.map(|url| OtlpMetricsConfig {
Expand Down
3 changes: 2 additions & 1 deletion libdd-data-pipeline/src/trace_exporter/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,8 @@ impl<C: HttpClientCapability + SleepCapability + MaybeSend + Sync + 'static> Tra
r.client_computed_stats = self.otlp_stats_enabled;
r
};
let request = map_traces_to_otlp(traces, &resource_info);
let request =
map_traces_to_otlp(traces, &resource_info, config.otel_trace_semantics_enabled);
let json_body = serde_json::to_vec(&request).map_err(|e| {
error!("OTLP JSON serialization error: {e}");
TraceExporterError::Internal(InternalErrorKind::InvalidWorkerState(e.to_string()))
Expand Down
Loading
Loading