Skip to content

chore(crashtracking): default errors intake crash report upload to be on #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gyuheon0h merged 3 commits into from
Apr 21, 2026
Merged

chore(crashtracking): default errors intake crash report upload to be on #1902

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90ed806
Default errors intake to be on
gyuheon0h Apr 21, 2026
f1c6a0f
Trigger ci
gyuheon0h Apr 21, 2026
9ead654
Merge branch 'main' into gyuheon0h/default-errors-intake-on
gyuheon0h Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions libdd-crashtracker/src/crash_info/errors_intake.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ impl ErrorsIntakeSettings {
errors_intake_dd_url: parse_env::str_not_empty(Self::DD_ERRORS_INTAKE_DD_URL),
shared_lib_debug: parse_env::bool(Self::_DD_SHARED_LIB_DEBUG).unwrap_or(false),
errors_intake_enabled: parse_env::bool(Self::DD_CRASHTRACKING_ERRORS_INTAKE_ENABLED)
.unwrap_or(false),
.unwrap_or(true),

agent_uds_socket_found: (|| {
#[cfg(unix)]
Expand Down Expand Up @@ -883,31 +883,22 @@ mod tests {
}

#[test]
fn test_errors_intake_enabled_flag() {
fn test_errors_intake_disabled_flag() {
let _lock = ENV_TEST_LOCK.lock().unwrap_or_else(|e| e.into_inner());

// Test default behavior (should be enabled)
clear_errors_intake_env();
let cfg = ErrorsIntakeConfig::from_env();
assert!(!cfg.is_errors_intake_enabled());

// Test explicitly enabled
std::env::set_var("DD_CRASHTRACKING_ERRORS_INTAKE_ENABLED", "true");
// Default behavior is enabled
let cfg = ErrorsIntakeConfig::from_env();
assert!(cfg.is_errors_intake_enabled());

// Test explicitly disabled
std::env::set_var("DD_CRASHTRACKING_ERRORS_INTAKE_ENABLED", "false");
let cfg = ErrorsIntakeConfig::from_env();
assert!(!cfg.is_errors_intake_enabled());

// Test with uploader
let uploader = ErrorsIntakeUploader::new(&None).unwrap();
assert!(!uploader.is_enabled());
assert!(uploader.is_enabled());

std::env::set_var("DD_CRASHTRACKING_ERRORS_INTAKE_ENABLED", "true");
std::env::set_var("DD_CRASHTRACKING_ERRORS_INTAKE_ENABLED", "false");
let uploader = ErrorsIntakeUploader::new(&None).unwrap();
assert!(uploader.is_enabled());
assert!(!uploader.is_enabled());
}

#[test]
Expand Down
Loading