Skip to content

Add HTTPX2Wrapper MVP as a standalone wrapper step#24307

Closed
mwdd146980 wants to merge 4 commits into
mwdd146980/httpx-migration-basefrom
mwdd146980/httpx2-wrapper-mvp
Closed

Add HTTPX2Wrapper MVP as a standalone wrapper step#24307
mwdd146980 wants to merge 4 commits into
mwdd146980/httpx-migration-basefrom
mwdd146980/httpx2-wrapper-mvp

Conversation

@mwdd146980

@mwdd146980 mwdd146980 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Reintroduces the HTTPX2Wrapper MVP — an httpx2-backed HTTP client behind the use_httpx flag — as its own step stacked on the httpx migration feature branch. It re-applies exactly what was reverted from the base in #24306 (revert-the-revert), so the diff is identical to the originally reviewed #23883.

Motivation

Per team decision, the wrapper ships as a separate step after the agnostic-protocol test migration lands, rather than living in the feature-branch base. Isolating it as its own PR lets the parity work (proxy #24023, auth-token) stack on the wrapper independently of the test-migration branches.

Verification

Re-applied by reverting the base revert commit, so the diff is byte-identical to the reviewed #23883. Confirmed at 19 files and 1686 insertions, the exact inverse of revert #24306. The wrapper is gated behind the use_httpx flag and defaults off, so no runtime behavior changes for existing checks. The wrapper's own httpx2 test suite ships with it and was green under #23883.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required. (qa/skip-qa: flag-gated behind use_httpx, default off; content identical to the already-reviewed Add HTTPX2Wrapper MVP #23883.)
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@mwdd146980 mwdd146980 added the qa/skip-qa Automatically skip this PR for the next QA label Jul 2, 2026
@datadog-official

datadog-official Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 3 Pipeline jobs failed

PR All | test / jb232c8c / Datadog Checks Base on Linux   View in Datadog   GitHub Actions

PR All Windows | test / jda96080 / Datadog Checks Base on Windows   View in Datadog   GitHub Actions

Validate repository | Run Validations / Validate   View in Datadog   GitHub Actions

🧪 2 Tests failed in 2 jobs

PR All | run   GitHub Actions

test_response_adapter_satisfies_protocol from test_response.py   View in Datadog
assert False
 &#43;  where False = isinstance(&lt;datadog_checks.base.utils.httpx2.HTTPX2ResponseAdapter object at 0x7f351a92fd60&gt;, HTTPResponseProtocol)

PR All Windows | run   GitHub Actions

test_response_adapter_satisfies_protocol from test_response.py   View in Datadog
assert False
 &#43;  where False = isinstance(&lt;datadog_checks.base.utils.httpx2.HTTPX2ResponseAdapter object at 0x0000024004675210&gt;, HTTPResponseProtocol)

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 020d670 | Docs | Datadog PR Page | Give us feedback!

mwdd146980 and others added 3 commits July 6, 2026 19:31
… raw response

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…-wrapper-mvp

# Conflicts:
#	datadog_checks_base/changelog.d/22676.added
#	datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/scraper/base_scraper.py
#	datadog_checks_base/tests/base/checks/openmetrics/test_v2/scraper/test_stream_connection_lines.py
@dd-octo-sts

dd-octo-sts Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Validation Report

Validation Description Status
dep Verify dependency pins are consistent and Agent-compatible

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (20)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@mwdd146980 mwdd146980 closed this Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base_package documentation qa/skip-qa Automatically skip this PR for the next QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant