Add HTTPX2Wrapper MVP as a standalone wrapper step#24307
Closed
mwdd146980 wants to merge 4 commits into
Closed
Conversation
Contributor
|
… raw response Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…-wrapper-mvp # Conflicts: # datadog_checks_base/changelog.d/22676.added # datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/scraper/base_scraper.py # datadog_checks_base/tests/base/checks/openmetrics/test_v2/scraper/test_stream_connection_lines.py
Contributor
Validation Report
Run Passed validations (20)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reintroduces the HTTPX2Wrapper MVP — an httpx2-backed HTTP client behind the
use_httpxflag — as its own step stacked on the httpx migration feature branch. It re-applies exactly what was reverted from the base in #24306 (revert-the-revert), so the diff is identical to the originally reviewed #23883.Motivation
Per team decision, the wrapper ships as a separate step after the agnostic-protocol test migration lands, rather than living in the feature-branch base. Isolating it as its own PR lets the parity work (proxy #24023, auth-token) stack on the wrapper independently of the test-migration branches.
Verification
Re-applied by reverting the base revert commit, so the diff is byte-identical to the reviewed #23883. Confirmed at 19 files and 1686 insertions, the exact inverse of revert #24306. The wrapper is gated behind the
use_httpxflag and defaults off, so no runtime behavior changes for existing checks. The wrapper's own httpx2 test suite ships with it and was green under #23883.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required. (qa/skip-qa: flag-gated behinduse_httpx, default off; content identical to the already-reviewed Add HTTPX2Wrapper MVP #23883.)backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged