Catch agnostic HTTP error types in prefect and swap the pagination raise#24284
Draft
mwdd146980 wants to merge 1 commit into
Draft
Catch agnostic HTTP error types in prefect and swap the pagination raise#24284mwdd146980 wants to merge 1 commit into
mwdd146980 wants to merge 1 commit into
Conversation
Widen PrefectClient.http_exceptions to admit the backend-agnostic HTTP error types alongside the requests ones, and raise HTTPInvalidURLError instead of requests' InvalidURL from check_pagination_url so the check stays correct after the httpx migration.
|
Contributor
Validation Report
Run Passed validations (20)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Widens
PrefectClient.http_exceptionsto admit the backend-agnostic HTTP error types alongside the existingrequestsones, and swaps theInvalidURLraise incheck_pagination_urlto the agnosticHTTPInvalidURLError. Mirrors the widened tuple into themock_prefect_clienttest fixture.Motivation
Part of the
requeststohttpxmigration (W1b workstream). Production funnels every HTTP call through the singleself.http_exceptionstuple, so widening it repairs all eight catch sites at once. Thecheck_pagination_urlraise is the one production behavior change in this PR: it must be swapped together with the tuple widening, since the raised value is caught by that same tuple, decoupling them would produce an unhandled exception rather than a clean test failure.No observable behavior change under the default
requestsbackend: the logged message text is identical either way and the exception never surfaces past the internal catch.Verification
Red-then-green on
test_paginate_events_rejects_external_next_page: swapping only the test assertion first produced a cleanAssertionError(the requestsInvalidURLis not anHTTPInvalidURLError), confirming the right red before the paired production edit landed.ddev test prefectpasses all 5 unit tests,ddev test -fs prefectis clean, and norequestsreference remains intests/test_unit.py.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged