[DBMON-6789] Implement database_identifier hooks in postgres#24278
Open
eric-weaver wants to merge 2 commits into
Open
[DBMON-6789] Implement database_identifier hooks in postgres#24278eric-weaver wants to merge 2 commits into
eric-weaver wants to merge 2 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 6ec24bc | Docs | Datadog PR Page | Give us feedback! |
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the hand-rolled
database_identifierproperty in thepostgrescheck with thedatabase_identifier_templateanddatabase_identifier_paramshooks now provided by the sharedDatabaseCheckbase class (#24250). The base class owns the caching and templating, so this removes the duplicated tag-loop /Template.safe_substitutelogic. Behavior is unchanged. The minimumdatadog-checks-baserequirement already includes the base implementation.Motivation
Support work for simplifying and unifying database check logic across DBM integrations.
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is mergedMade with Cursor