fix(ci): PHP profiler language tests YAML invalid#4004
Merged
Conversation
|
realFlowControl
force-pushed
the
realFlowControl-patch-1
branch
from
a0ef1b2 to
52dd313
Compare
realFlowControl
force-pushed
the
realFlowControl-patch-1
branch
from
52dd313 to
030cc31
Compare
bwoebi
approved these changes
Jun 22, 2026
bwoebi
left a comment
bwoebi
left a comment
Collaborator
There was a problem hiding this comment.
Requiring no quoting for values in yaml was indeed a mistake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The last cleanup commit (failing if profiling is not loaded in PHP Language Tests) in #3364 actually broke the YAML and it failed in complete silence. Turns out: if there is a : sign somewhere in the list, it is not a array of strings in YAML anymore, but a map ...
On a personal note: YAML was a mistake
Reviewer checklist